Sqoop
  1. Sqoop
  2. SQOOP-1104

Sqoop2: Allow versioned patches in the PreCommit hook

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.99.2
    • Fix Version/s: 1.99.3
    • Component/s: None
    • Labels:
      None

      Description

      The PreCommit hook introduced in SQOOP-1082 is expecting that patches will be named in form (bug)SQOOP-XXXX.suffix. On SQOOP-971, I've noticed that some contributors are versioning the patches with patter SQOOP-XXX.Y.patch. This seems like a good idea, so I would like to support that in the PreCommit hook.

      1. bugSQOOP-1104.patch
        0.8 kB
        Jarek Jarcec Cecho
      2. bugSQOOP-1104.patch
        0.8 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #421 (See https://builds.apache.org/job/Sqoop2-hadoop200/421/)
          SQOOP-1104. Sqoop2: Allow versioned patches in the PreCommit hook (Revision 60a909f30b9705cf9a0339a0a76932cf1c0deb8a)

          Result = SUCCESS
          hshreedharan : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=60a909f30b9705cf9a0339a0a76932cf1c0deb8a
          Files :

          • dev-support/test-patch.py
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #421 (See https://builds.apache.org/job/Sqoop2-hadoop200/421/ ) SQOOP-1104 . Sqoop2: Allow versioned patches in the PreCommit hook (Revision 60a909f30b9705cf9a0339a0a76932cf1c0deb8a) Result = SUCCESS hshreedharan : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=60a909f30b9705cf9a0339a0a76932cf1c0deb8a Files : dev-support/test-patch.py
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #426 (See https://builds.apache.org/job/Sqoop2-hadoop100/426/)
          SQOOP-1104. Sqoop2: Allow versioned patches in the PreCommit hook (Revision 60a909f30b9705cf9a0339a0a76932cf1c0deb8a)

          Result = SUCCESS
          hshreedharan : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=60a909f30b9705cf9a0339a0a76932cf1c0deb8a
          Files :

          • dev-support/test-patch.py
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #426 (See https://builds.apache.org/job/Sqoop2-hadoop100/426/ ) SQOOP-1104 . Sqoop2: Allow versioned patches in the PreCommit hook (Revision 60a909f30b9705cf9a0339a0a76932cf1c0deb8a) Result = SUCCESS hshreedharan : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=60a909f30b9705cf9a0339a0a76932cf1c0deb8a Files : dev-support/test-patch.py
          Hide
          Hari Shreedharan added a comment -

          Patch committed, thanks Jarcec!

          Show
          Hari Shreedharan added a comment - Patch committed, thanks Jarcec!
          Hide
          ASF subversion and git services added a comment -

          Commit 60a909f30b9705cf9a0339a0a76932cf1c0deb8a in branch refs/heads/sqoop2 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=60a909f ]

          SQOOP-1104. Sqoop2: Allow versioned patches in the PreCommit hook

          (Jarek Jarcec Cecho via Hari Shreedharan)

          Show
          ASF subversion and git services added a comment - Commit 60a909f30b9705cf9a0339a0a76932cf1c0deb8a in branch refs/heads/sqoop2 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=60a909f ] SQOOP-1104 . Sqoop2: Allow versioned patches in the PreCommit hook (Jarek Jarcec Cecho via Hari Shreedharan)
          Hide
          Hari Shreedharan added a comment -

          +1.

          Show
          Hari Shreedharan added a comment - +1.
          Hide
          Jarek Jarcec Cecho added a comment -

          Of course Hari Shreedharan, attaching updated patch (verified on your SQOOP-659).

          Show
          Jarek Jarcec Cecho added a comment - Of course Hari Shreedharan , attaching updated patch (verified on your SQOOP-659 ).
          Hide
          Hari Shreedharan added a comment -

          Jarcec,

          This looks good. Could you also add support for SQOOP-XXX-Y.patch? I have noticed that is a common pattern too (I use it myself!)

          Show
          Hari Shreedharan added a comment - Jarcec, This looks good. Could you also add support for SQOOP-XXX-Y.patch? I have noticed that is a common pattern too (I use it myself!)

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development