Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-19787

Different default regParam values in ALS

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0, 2.0.1, 2.0.2, 2.1.0
    • Fix Version/s: 2.2.0
    • Component/s: MLlib
    • Labels:
      None

      Description

      In the ALS method the default values of regParam do not match within the same file (lines 224 and 714). In one place we set it to 1.0 and in the other to 0.1.

      We can change the one of train() method to 0.1. The method is marked with DeveloperApi so it should not affect the users. Based on what I saw, whenever we use the particular method we provide all parameters, so the default does not matter. Only exception is the unit-tests on ALSSuite but the change does not break them.

      This change was discussed on a separate PR and Nick Pentreath suggested to create a separate PR & ticket.

        Issue Links

          Activity

          Hide
          mlnick Nick Pentreath added a comment -

          Issue resolved by pull request 17121
          https://github.com/apache/spark/pull/17121

          Show
          mlnick Nick Pentreath added a comment - Issue resolved by pull request 17121 https://github.com/apache/spark/pull/17121
          Hide
          apachespark Apache Spark added a comment -

          User 'datumbox' has created a pull request for this issue:
          https://github.com/apache/spark/pull/17121

          Show
          apachespark Apache Spark added a comment - User 'datumbox' has created a pull request for this issue: https://github.com/apache/spark/pull/17121

            People

            • Assignee:
              Unassigned
              Reporter:
              datumbox Vasilis Vryniotis
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development