[SOLR-9995] refactor / cleanup PointFields code and overall asumptions about numerics

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 7.0, 7.1, 8.0
• Labels: numeric-tries-to-points
• Assignee: Steven Rowe
• Reporter: Tomas Eduardo Fernandez Lobbe
• Created: 19/Jan/17 02:07
• Updated: 08/Jun/19 15:32
• Resolved: 26/Jul/17 16:43

Description

Generalizing this issue to serve as a parent for small individual improvements/cleanup/refactoring subtasks that can be made to various places in the solr code where we deal with Points fields and other older types of numeric fields.

---

Original description...

As Suggested by Adrien in SOLR-8396

in the below change, it looks like the logic that you apply to point fields would work in the general case and be as efficient?

+    if (ft.isPointField()) {
+      for (String term : terms) {
+        int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), parsed.docs);
+        res.add(term, count);
+      }
+    } else {
+      for (String term : terms) {
+        String internal = ft.toInternal(term);
+        int count = searcher.numDocs(new TermQuery(new Term(field, internal)), parsed.docs);
+        res.add(term, count);
+      }
     }

Issue Links

• is related to: SOLR-10924 PointField multivalued docValues don't "dedup" like TrieField
• is related to: SOLR-10797 Numeric PointsFields: test ranges with IndexOrDocValuesQuery
• relates to: SOLR-8396 Add support for PointFields in Solr

Sub-Tasks

• generalize some SimpleFacet logic realted to PointsField vs other fields: Closed
• refactor "instanceof TrieFooField || instanceof FooPointsField" to use "FooValueFieldType" marker interface: Resolved
• schema-point.xml and TestPointFields have suspicious assumptions about useDocValuesAsStored: Resolved
• numeric PointsFields: need more testing of sortMissing=last|first for: Resolved
• CurrencyField should be changed from TrieLongField to LongPointField for underlying raw-polyfield: Resolved
• Remove trie field types and fields from example schemas: Closed
• Switch trie numeric/date fields to points in data-driven-enabled example and test schemas: Resolved
• Numeric PointsFields: need more testing of sorting/boosting by numeric functions: Resolved
• Numeric PointsFields: test multivalued sort using field(name, min|max) syntax: Resolved
• TestPointFields: increase randomized testing of non-trivial values: Closed
• BBoxField does not support point-based number sub-fields: Resolved
• remove useless valType from ExternalFileField: Resolved