Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9694

PostFilters' DelegatingCollector.finish() is not called during first and second grouping phases

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 6.2.1
    • None
    • search
    • None

    Description

      The finish() method has been added to DelegatingCollector as part of SOLR-5020.

      Grouping has been updated to call it by SOLR-5230.

      Some calls made during the grouping process fail to call the finish() method even thought they properly call the collect() one.

      I'm attaching a patch with updated tests that reproduce the issue, as well as a candidate fix.

      Attachments

        1. SOLR-9694-v1.patch
          30 kB
          Julien Massenet

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. SOLR-7520 Post filter DelegatingCollector.finish not called for multi-shard queries specifying grouping

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. SOLR-5020 Add finish() method to DelegatingCollector

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. SOLR-5230 Call DelegatingCollector.finish() during grouping

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              Unassigned Unassigned
              jmassenet-rakuten Julien Massenet
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: