[SOLR-7520] Post filter DelegatingCollector.finish not called for multi-shard queries specifying grouping

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 4.8, 5.2.1
• Component/s: search
• Assignee: Unassigned
• Reporter: Eric Wheeler
• Created: 10/May/15 00:12
• Updated: 23/Sep/20 01:23

Description

The finish method for a DelegatingCollector post filter is not being called for queries specifying a fq filter, multiple shards, and grouping options.

Recommend adding the following code to org.apache.solr.search.grouping.CommandHandler.searchWithTimeLimiter to call finish (if a DelegatingCollector is available) after calling search, but before obtaining totalHitCount:

org.apache.solr.search.grouping.CommandHandler line ~218

    try {
      searcher.search(query, luceneFilter, collector);
    } catch (TimeLimitingCollector.TimeExceededException x) {
      partialResults = true;
      logger.warn( "Query: " + query + "; " + x.getMessage() );
    }

    /* Call finish of DelegatingCollector to complete post processing
       for multi-shard queries */
    if (filter.postFilter != null) {
      filter.postFilter.finish();
    }
    /* END: Call finish of DelegatingCollector to complete post processing
       for multi-shard queries */

    if (includeHitCount) {
      totalHitCount = hitCountCollector.getTotalHits();
    }

Issue Links

• is related to: SOLR-9694 PostFilters' DelegatingCollector.finish() is not called during first and second grouping phases