[SOLR-9430] Locale in <propertyWriter in DIH is looked up based on Locale displayName (language tag "en-US" or legacy name "en_US" does not work, English works)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.1
• Fix Version/s: 6.2.1, 6.3, 7.0
• Component/s: contrib - DataImportHandler, update
• Labels: DIH SimpePropertiesWriter locale propertyWriter

Environment

all

• Assignee: Uwe Schindler
• Reporter: Boris Steiner
• Created: 23/Aug/16 12:07
• Updated: 08/Jun/19 15:37
• Resolved: 12/Sep/16 11:57

Description

having a DIH with DB datasource and propertyWriter such as:

<propertyWriter dateFormat="yyyy-MM-dd HH:mm:ss.SSSSSS" type="SimplePropertiesWriter" locale="en_US" />

does not work with locale in form en_US as mentioned in documentation;
Locale is being looked up by Locale.getDisplayName() which returns human readable representation as opposed to Locale.toLanguageTag, which returns form such as en-US.

Propertywirter with locale in this form works:
<propertyWriter dateFormat="yyyy-MM-dd HH:mm:ss.SSSSSS" type="SimplePropertiesWriter" locale="Slovak" />

Problematic line code:
https://github.com/apache/lucene-solr/blob/branch_6_1/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/SimplePropertiesWriter.java#L95

Issue Links

• relates to: LUCENE-6978 Make LuceneTestCase use language tags instead of parsing locales by hand