[SOLR-9217] {!join score=..}.. should delay join to createWeight

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.1
• Fix Version/s: 6.6, 7.0
• Component/s: query parsers
• Labels: newbie newdev
• Assignee: Unassigned
• Reporter: Mikhail Khludnev
• Created: 16/Jun/16 20:07
• Updated: 30/Jun/17 15:32
• Resolved: 24/Apr/17 08:14

Description

ScoreJoinQParserPlugin.XxxCoreJoinQuery executes JoinUtil.createJoinQuery on rewrite(), but it's inefficient in filter(...) syntax or fq I suppose it's filter() only problem, not fq. It's better to do that in createWeigh() as it's done in classic Solr JoinQuery, JoinQParserPlugin.
All existing tests is enough, we just need to assert rewrite behavior - it should rewrite on enclosing range query or so, and doesn't on plain term query.

Issue Links

• breaks: SOLR-10986 TestScoreJoinQPScore.testDeleteByScoreJoinQuery() failure: mismatch: '0'!='1' @ response/numFound
• relates to: SOLR-6234 Scoring modes for query time join