Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9217

{!join score=..}.. should delay join to createWeight

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.1
    • Fix Version/s: 6.6, 7.0
    • Component/s: query parsers
    • Labels:

      Description

      ScoreJoinQParserPlugin.XxxCoreJoinQuery executes JoinUtil.createJoinQuery on rewrite(), but it's inefficient in filter(...) syntax or fq I suppose it's filter() only problem, not fq. It's better to do that in createWeigh() as it's done in classic Solr JoinQuery, JoinQParserPlugin.
      All existing tests is enough, we just need to assert rewrite behavior - it should rewrite on enclosing range query or so, and doesn't on plain term query.

        Attachments

        1. SOLR-9217.patch
          3 kB
          gopikannan venugopalsamy
        2. SOLR-9217.patch
          4 kB
          Mikhail Khludnev
        3. SOLR_9217.patch
          3 kB
          Andrey Kudryavtsev

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                mkhludnev Mikhail Khludnev
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: