[SOLR-8280] Schemaless features don't work reliably with SolrCoreAware sim factory -- example: SchemaSimilarityFactory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0
• Fix Version/s: 5.4, 6.0
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 12/Nov/15 00:33
• Updated: 26/Sep/23 12:44
• Resolved: 19/Nov/15 18:03

Description

SOLR-8271 uncovered problems with using SchemaSimilarityFactory + schemaless features. While the broader problems of SolrCoreAware objects inited after the SolrCore was live have been spun off into SOLR-8311 this issue focuses on fixing & testing the core problem of ensuring SchemaSimilarityFactory + schemaless features function together.

original bug report

Something about the code path(s) involved in TestCloudSchemaless & ChangedSchemaMergeTest don't play nicely with a SimilarityFactory that is SolrCoreAware – notably: SchemaSimilarityFactory.

I discovered this while trying to implement SOLR-8271, but it can be reproduced trivially by modifying the schema-add-schema-fields-update-processor.xml file used by TestCloudSchemaless (and hardcoded in java schema used by ChangedSchemaMergeTest) to refer to SchemaSimilarityFactory explicitly. Other cloud tests (such as CollectionReloadTest) or cloud+schemaless (ex: TestCloudManagedSchema) tests don't seem to demonstrate the same problem.

Issue Links

• blocks: SOLR-8271 use SchemaSimilarityFactory as default when no explicit (top level) sim is configured
• is related to: SOLR-8311 SolrCoreAware and ResourceLoaderAware lifecyel is fragile - particularly with objects that can be created after SolrCore is live
• is related to: SOLR-16998 Adopt JSR-330 dependency injection