Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8280

Schemaless features don't work reliably with SolrCoreAware sim factory -- example: SchemaSimilarityFactory

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      SOLR-8271 uncovered problems with using SchemaSimilarityFactory + schemaless features. While the broader problems of SolrCoreAware objects inited after the SolrCore was live have been spun off into SOLR-8311 this issue focuses on fixing & testing the core problem of ensuring SchemaSimilarityFactory + schemaless features function together.

      original bug report

      Something about the code path(s) involved in TestCloudSchemaless & ChangedSchemaMergeTest don't play nicely with a SimilarityFactory that is SolrCoreAware – notably: SchemaSimilarityFactory.

      I discovered this while trying to implement SOLR-8271, but it can be reproduced trivially by modifying the schema-add-schema-fields-update-processor.xml file used by TestCloudSchemaless (and hardcoded in java schema used by ChangedSchemaMergeTest) to refer to SchemaSimilarityFactory explicitly. Other cloud tests (such as CollectionReloadTest) or cloud+schemaless (ex: TestCloudManagedSchema) tests don't seem to demonstrate the same problem.

        Attachments

        1. SOLR-8280.patch
          1 kB
          Hoss Man
        2. SOLR-8280.patch
          2 kB
          Hoss Man
        3. SOLR-8280.patch
          7 kB
          Hoss Man
        4. SOLR-8280.patch
          15 kB
          Hoss Man
        5. SOLR-8280__broken__resource_loader_experiment.patch
          10 kB
          Hoss Man

          Issue Links

            Activity

              People

              • Assignee:
                hossman Hoss Man
                Reporter:
                hossman Hoss Man
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: