[SOLR-8145] bin/solr script oom_killer arg incorrect

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.2.1
• Fix Version/s: 5.5.1, 6.0
• Component/s: scripts and tools
• Assignee: Timothy Potter
• Reporter: Nate Dire
• Created: 08/Oct/15 19:18
• Updated: 22/Apr/16 00:33
• Resolved: 22/Apr/16 00:22

Description

I noticed the oom_killer script wasn't working in our 5.2 deployment.

In the bin/solr script, the OnOutOfMemoryError option is being passed as an arg to the jar rather than to the JVM. I moved it ahead of -jar and verified it shows up in the JVM args in the UI.

   # run Solr in the background
    nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
    "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \

Also, I'm not sure what the SOLR_PORT and SOLR_LOGS_DIR args are doing--they don't appear to be positional arguments to the jar.

Attaching a patch against 5.2.

Issue Links

• relates to: SOLR-7043 Refactor SolrCLI, bin\solr, bin\solr.cmd to be more unit-testable and less OS specific