Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8145

bin/solr script oom_killer arg incorrect

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.2.1
    • Fix Version/s: 5.5.1, 6.0
    • Component/s: scripts and tools
    • Labels:
      None

      Description

      I noticed the oom_killer script wasn't working in our 5.2 deployment.

      In the bin/solr script, the OnOutOfMemoryError option is being passed as an arg to the jar rather than to the JVM. I moved it ahead of -jar and verified it shows up in the JVM args in the UI.

         # run Solr in the background
          nohup "$JAVA" "${SOLR_START_OPTS[@]}" $SOLR_ADDL_ARGS -jar start.jar \
          "-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT $SOLR_LOGS_DIR" "${SOLR_JETTY_CONFIG[@]}" \
      

      Also, I'm not sure what the SOLR_PORT and SOLR_LOGS_DIR args are doing--they don't appear to be positional arguments to the jar.

      Attaching a patch against 5.2.

        Attachments

        1. SOLR-8145.patch
          0.8 kB
          Nate Dire
        2. SOLR-8145.patch
          0.8 kB
          Jurian Broertjes
        3. SOLR-8145.patch
          0.8 kB
          Jurian Broertjes

          Issue Links

            Activity

              People

              • Assignee:
                thelabdude Timothy Potter
                Reporter:
                nated Nate Dire
              • Votes:
                3 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: