[SOLR-6246] Core fails to reload when AnalyzingInfixSuggester is used as a Suggester

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.8, 4.8.1, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4
• Fix Version/s: 6.4.1, 6.5, 7.0
• Component/s: SearchComponents - other
• Assignee: Steven Rowe
• Reporter: Varun Thacker
• Created: 15/Jul/14 05:42
• Updated: 21/Nov/19 00:41
• Resolved: 03/Feb/17 23:40

Description

LUCENE-5477 - added near-real-time suggest building to AnalyzingInfixSuggester. One of the changes that went in was a writer is persisted now to support real time updates via the add() and update() methods.

When we call Solr's reload command, a new instance of AnalyzingInfixSuggester is created. When trying to create a new writer on the same Directory a lock cannot be obtained and Solr fails to reload the core.

Also when AnalyzingInfixLookupFactory throws a RuntimeException we should pass along the original message.

I am not sure what should be the approach to fix it. Should we have a reloadHook where we close the writer?

Issue Links

• is broken by: LUCENE-7670 AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index
• is depended upon by: SOLR-9435 Un-recoverable state while using AnalyzingInfixLookupFactory with collection RELOAD action
• is duplicated by: SOLR-7747 BlendedInfixSuggester doesn't support Solr core reload
• is duplicated by: SOLR-9435 Un-recoverable state while using AnalyzingInfixLookupFactory with collection RELOAD action
• is related to: SOLR-7747 BlendedInfixSuggester doesn't support Solr core reload
• is related to: LUCENE-7564 AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()
• relates to: SOLR-9435 Un-recoverable state while using AnalyzingInfixLookupFactory with collection RELOAD action
• links to: GitHub Pull Request #96