[LUCENE-7670] AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.4
• Fix Version/s: 6.4.1, 6.5, 7.0
• Lucene Fields: New
• Assignee: Steven Rowe
• Reporter: Steven Rowe
• Created: 31/Jan/17 05:57
• Updated: 28/Aug/22 15:10
• Resolved: 31/Jan/17 13:24

Description

In tests I'm working on under SOLR-6246, I can see that attempts to open an AnalyzingInfixSuggester over a previously-built index fail, because the old suggester's IndexWriter lock is never released. The issue is that an IndexWriter is created in order to create a SearcherManager over the previously built index. But this is not necessary: SearcherManager has a ctor that takes a directory instead of an IndexWriter.

Issue Links

• breaks: SOLR-6246 Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
• is broken by: LUCENE-7564 AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()