Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7670

AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.4
    • Fix Version/s: 7.0, 6.5, 6.4.1
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      In tests I'm working on under SOLR-6246, I can see that attempts to open an AnalyzingInfixSuggester over a previously-built index fail, because the old suggester's IndexWriter lock is never released. The issue is that an IndexWriter is created in order to create a SearcherManager over the previously built index. But this is not necessary: SearcherManager has a ctor that takes a directory instead of an IndexWriter.

        Issue Links

          Activity

          Hide
          steve_rowe Steve Rowe added a comment -

          Patch that uses the SearcherManager(Directory,...) ctor instead of the SM(IndexWriter,...) ctor in the case of opening a suggester over an already built index.

          Committing shortly.

          Show
          steve_rowe Steve Rowe added a comment - Patch that uses the SearcherManager(Directory,...) ctor instead of the SM(IndexWriter,...) ctor in the case of opening a suggester over an already built index. Committing shortly.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit dbcfe698706fc2a87199f913bfd2185147b75e62 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbcfe69 ]

          LUCENE-7670: AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index

          Show
          jira-bot ASF subversion and git services added a comment - Commit dbcfe698706fc2a87199f913bfd2185147b75e62 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbcfe69 ] LUCENE-7670 : AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 967b66fb5bf08c876632ada63751027b8efce5dc in lucene-solr's branch refs/heads/branch_6x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=967b66f ]

          LUCENE-7670: changes entry

          Show
          jira-bot ASF subversion and git services added a comment - Commit 967b66fb5bf08c876632ada63751027b8efce5dc in lucene-solr's branch refs/heads/branch_6x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=967b66f ] LUCENE-7670 : changes entry
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c1fe88b7c6fa861d5101f9702a7832d29b8032ee in lucene-solr's branch refs/heads/master from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c1fe88b ]

          LUCENE-7670: AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index

          Show
          jira-bot ASF subversion and git services added a comment - Commit c1fe88b7c6fa861d5101f9702a7832d29b8032ee in lucene-solr's branch refs/heads/master from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c1fe88b ] LUCENE-7670 : AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 33861527914770b556528b66c90bc6ed421c2034 in lucene-solr's branch refs/heads/master from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3386152 ]

          LUCENE-7670: changes entry

          Show
          jira-bot ASF subversion and git services added a comment - Commit 33861527914770b556528b66c90bc6ed421c2034 in lucene-solr's branch refs/heads/master from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3386152 ] LUCENE-7670 : changes entry
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5cee247c4634dc7d70e2cec5eecfd04a38bcf1a8 in lucene-solr's branch refs/heads/branch_6_4 from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5cee247 ]

          LUCENE-7670: AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5cee247c4634dc7d70e2cec5eecfd04a38bcf1a8 in lucene-solr's branch refs/heads/branch_6_4 from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5cee247 ] LUCENE-7670 : AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8ce4ffc4f92ba9623a61bdcdbc9cafbdfdc3e4bd in lucene-solr's branch refs/heads/branch_6_4 from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8ce4ffc ]

          LUCENE-7670: changes entry

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8ce4ffc4f92ba9623a61bdcdbc9cafbdfdc3e4bd in lucene-solr's branch refs/heads/branch_6_4 from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8ce4ffc ] LUCENE-7670 : changes entry
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0acddf44e670627a70daabf645159b873b79bd9d in lucene-solr's branch refs/heads/branch_6x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0acddf4 ]

          LUCENE-7670: move changes entry under 6.4.1

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0acddf44e670627a70daabf645159b873b79bd9d in lucene-solr's branch refs/heads/branch_6x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0acddf4 ] LUCENE-7670 : move changes entry under 6.4.1
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2e651010fc6e1fc09323363ecd77d07905526df5 in lucene-solr's branch refs/heads/master from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2e65101 ]

          LUCENE-7670: move changes entry under 6.4.1

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2e651010fc6e1fc09323363ecd77d07905526df5 in lucene-solr's branch refs/heads/master from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2e65101 ] LUCENE-7670 : move changes entry under 6.4.1

            People

            • Assignee:
              steve_rowe Steve Rowe
              Reporter:
              steve_rowe Steve Rowe
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development