[SOLR-5616] Make grouping code use response builder needDocList

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.4
• Assignee: Dennis Gove
• Reporter: Steven Bower
• Created: 07/Jan/14 17:02
• Updated: 05/Jan/17 11:50
• Resolved: 05/Jan/17 00:14

Description

Right now the grouping code does this to check if it needs to generate a docList for grouped results:

if (rb.doHighlights || rb.isDebug() || params.getBool(MoreLikeThisParams.MLT, false) ){
...
}

this is ugly because any new component that needs a doclist, from grouped results, will need to modify QueryComponent to add a check to this if. Ideally this should just use the rb.isNeedDocList() flag...

Coincidentally this boolean is really never used at for non-grouped results it always gets generated..