Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5616

Make grouping code use response builder needDocList

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4
    • Component/s: None
    • Labels:
      None

      Description

      Right now the grouping code does this to check if it needs to generate a docList for grouped results:

      if (rb.doHighlights || rb.isDebug() || params.getBool(MoreLikeThisParams.MLT, false) ){
      ...
      }
      

      this is ugly because any new component that needs a doclist, from grouped results, will need to modify QueryComponent to add a check to this if. Ideally this should just use the rb.isNeedDocList() flag...

      Coincidentally this boolean is really never used at for non-grouped results it always gets generated..

        Attachments

        1. SOLR-5616.patch
          6 kB
          Steven Bower
        2. SOLR-5616.patch
          3 kB
          Erick Erickson
        3. SOLR-5616.patch
          3 kB
          Keith Laban

          Activity

            People

            • Assignee:
              dpgove Dennis Gove
              Reporter:
              sbower Steven Bower
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: