Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5285

Solr response format should support child Docs

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.9, 6.0
    • None
    • None

    Description

      Solr has added support for taking childDocs as input ( only XML till now ). It's currently used for BlockJoinQuery.

      I feel that if a user indexes a document with child docs, even if he isn't using the BJQ features and is just searching which results in a hit on the parentDoc, it's childDocs should be returned in the response format.

      Chris Hostetter (Unused) on IRC suggested that the DocTransformers would be the place to add childDocs to the response.

      Now given a docId one needs to find out all the childDoc id's. A couple of approaches which I could think of are
      1. Maintain the relation between a parentDoc and it's childDocs during indexing time in maybe a separate index?
      2. Somehow emulate what happens in ToParentBlockJoinQuery.nextDoc() - Given a parentDoc it finds out all the childDocs but this requires a childScorer.

      Am I missing something obvious on how to find the relation between a parentDoc and it's childDocs because none of the above solutions for this look right.

      Attachments

        1. SOLR-5285.patch
          8 kB
          Varun Thacker
        2. SOLR-5285.patch
          14 kB
          Varun Thacker
        3. SOLR-5285.patch
          25 kB
          Varun Thacker
        4. SOLR-5285.patch
          25 kB
          Varun Thacker
        5. SOLR-5285.patch
          26 kB
          Varun Thacker
        6. SOLR-5285.patch
          27 kB
          Chris M. Hostetter
        7. SOLR-5285.patch
          36 kB
          Varun Thacker
        8. SOLR-5285.patch
          36 kB
          Varun Thacker
        9. SOLR-5285.patch
          48 kB
          Varun Thacker
        10. SOLR-5285.patch
          50 kB
          Chris M. Hostetter
        11. SOLR-5285.patch
          52 kB
          Varun Thacker
        12. SOLR-5285.patch
          51 kB
          Chris M. Hostetter
        13. SOLR-5285.patch
          49 kB
          Varun Thacker
        14. SOLR-5285.patch
          50 kB
          Varun Thacker
        15. javabin_backcompat_child_docs.bin
          0.1 kB
          Varun Thacker

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hossman Chris M. Hostetter
            varun Varun Thacker
            Votes:
            11 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment