Solr
  1. Solr
  2. SOLR-6048

Fix asserts for SolrDocument, SolrInputDocument and SolrInputField in SolrTestCaseJ4

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.9, Trunk
    • Component/s: None
    • Labels:
      None

      Description

      SOLR-5265 added these asserts to check equality of SolrDocument, SolrInputDocument and SolrInputField instead of adding a compare method to any of these classes.

      But these are actually compare methods. So we should rename them to compareSolrDocument() etc. and in TestJavaBinCodec fix the usage. Currently in TestJavaBinCodec the backcompat test is broken.

      1. SOLR-6048.patch
        8 kB
        Varun Thacker
      2. SOLR-6048.patch
        2 kB
        Varun Thacker
      3. SOLR-6048.patch
        3 kB
        Varun Thacker

        Issue Links

          Activity

          Varun Thacker created issue -
          Varun Thacker made changes -
          Field Original Value New Value
          Attachment SOLR-6048.patch [ 12643733 ]
          Varun Thacker made changes -
          Description SOLR-5873 added these asserts to check equality of SolrDocument, SolrInputDocument and SolrInputField instead of adding a compare method to any of these classes.

          But these are actually compare methods. So we should rename them to compareSolrDocument() etc. and in TestJavaBinCodec fix the usage. Currently in TestJavaBinCodec the backcompat test is broken.
          SOLR-5265 added these asserts to check equality of SolrDocument, SolrInputDocument and SolrInputField instead of adding a compare method to any of these classes.

          But these are actually compare methods. So we should rename them to compareSolrDocument() etc. and in TestJavaBinCodec fix the usage. Currently in TestJavaBinCodec the backcompat test is broken.
          Varun Thacker made changes -
          Fix Version/s 4.9 [ 12326731 ]
          Fix Version/s 5.0 [ 12321664 ]
          Varun Thacker made changes -
          Link This issue blocks SOLR-5285 [ SOLR-5285 ]
          Varun Thacker made changes -
          Attachment SOLR-6048.patch [ 12650027 ]
          Varun Thacker made changes -
          Attachment SOLR-6048.patch [ 12650028 ]
          Noble Paul made changes -
          Assignee Noble Paul [ noble.paul ]
          Noble Paul made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Noble Paul
              Reporter:
              Varun Thacker
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development