Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6048

Fix asserts for SolrDocument, SolrInputDocument and SolrInputField in SolrTestCaseJ4

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.9, 6.0
    • None
    • None

    Description

      SOLR-5265 added these asserts to check equality of SolrDocument, SolrInputDocument and SolrInputField instead of adding a compare method to any of these classes.

      But these are actually compare methods. So we should rename them to compareSolrDocument() etc. and in TestJavaBinCodec fix the usage. Currently in TestJavaBinCodec the backcompat test is broken.

      Attachments

        1. SOLR-6048.patch
          3 kB
          Varun Thacker
        2. SOLR-6048.patch
          2 kB
          Varun Thacker
        3. SOLR-6048.patch
          8 kB
          Varun Thacker

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. SOLR-5285 Solr response format should support child Docs

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              noble.paul Noble Paul
              varun Varun Thacker
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: