[SOLR-4931] Override exact signatures (with generics) in SolrDeletionPolicy

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.3
• Fix Version/s: 4.4
• Assignee: Shalin Shekhar Mangar
• Reporter: Shalin Shekhar Mangar
• Created: 17/Jun/13 17:23
• Updated: 23/Jul/13 18:38
• Resolved: 17/Jun/13 18:41

Description

LUCENE-4876 changed the IndexDeletionPolicy to an abstract class. The SolrDeletionPolicy extends this class but overrides the onInit and onCommit methods with non generic parameters. This makes people who extend SolrDeletionPolicy (even though we don't recommend doing that) run into a Java6 bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6775192

The workaround is to use reflection to call the parent class's method. I propose that we change SolrDeletionPolicy to override parent's methods with the exact signature.