Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4931

Override exact signatures (with generics) in SolrDeletionPolicy

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.3
    • Fix Version/s: 4.4
    • Component/s: None
    • Labels:
      None

      Description

      LUCENE-4876 changed the IndexDeletionPolicy to an abstract class. The SolrDeletionPolicy extends this class but overrides the onInit and onCommit methods with non generic parameters. This makes people who extend SolrDeletionPolicy (even though we don't recommend doing that) run into a Java6 bug:
      http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6775192

      The workaround is to use reflection to call the parent class's method. I propose that we change SolrDeletionPolicy to override parent's methods with the exact signature.

        Attachments

        1. SOLR-4931.patch
          4 kB
          Shalin Shekhar Mangar
        2. SOLR-4931.patch
          3 kB
          Shalin Shekhar Mangar

          Activity

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              shalinmangar Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: