Solr
  1. Solr
  2. SOLR-4818

Refactorings to simplify loading, organization, sharing of cores, etc.

    Details

    • Type: Improvement Improvement
    • Status: In Progress
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Hello,

      I want to follow up IRC log from SOLR-1393.

      At least, questions are:

      • how much guice do you accept: should it load only user's plugin or fully substitute solrconfig.xml?
      • is there any observable stages for this migration?

      I'm ccing Grant Ingersoll Robert Muir as persons who provided an interest or/and concerns about Guice.

      Please vote/ban!

        Issue Links

          Activity

          Hide
          Grant Ingersoll added a comment -

          User's plugin is logical starting point, but I could see it eventually replacing solrconfig (or at least, we could inject a version that could read old solrconfigs).

          I've played around w/ Guice in Solr for replacing the up front servlet filter stuff too, but don't have anything publishable at this point in time.

          Show
          Grant Ingersoll added a comment - User's plugin is logical starting point, but I could see it eventually replacing solrconfig (or at least, we could inject a version that could read old solrconfigs). I've played around w/ Guice in Solr for replacing the up front servlet filter stuff too, but don't have anything publishable at this point in time.
          Hide
          Mark Miller added a comment -

          fully substitute solrconfig.xml?

          I certainly don't think it's a substitute - at best it's a nice alternative. We don't want to move configuration to java as the only method of configuration. A ReST API could substitute though.

          Show
          Mark Miller added a comment - fully substitute solrconfig.xml? I certainly don't think it's a substitute - at best it's a nice alternative. We don't want to move configuration to java as the only method of configuration. A ReST API could substitute though.
          Hide
          Grant Ingersoll added a comment - - edited

          I've started a branch for this at https://svn.apache.org/repos/asf/lucene/dev/branches/solr_guice_restlet/

          It is totally experimental and a long ways away from being anything real.

          That being said, I think it solves a number of things:

          1. It will be easier to embed Solr into whatever container, including something like Netty
          2. More testability b/c it is is super easy to inject alternate views of the world
          3. SOLR-5091 – Easier creation of APIs
          4. SOLR-5103
          5. SOLR-5102
          6. Guice is just so much cleaner than all kinds of factories, etc.
          7. More extensible
          Show
          Grant Ingersoll added a comment - - edited I've started a branch for this at https://svn.apache.org/repos/asf/lucene/dev/branches/solr_guice_restlet/ It is totally experimental and a long ways away from being anything real. That being said, I think it solves a number of things: It will be easier to embed Solr into whatever container, including something like Netty More testability b/c it is is super easy to inject alternate views of the world SOLR-5091 – Easier creation of APIs SOLR-5103 SOLR-5102 Guice is just so much cleaner than all kinds of factories, etc. More extensible
          Hide
          Jack Krupansky added a comment -

          Could somebody give this issue a more accurate and descriptive summary line? I mean it's not really "Guice OR Solr" is it? More like "Guice AND Solr", right? Thanks.

          Show
          Jack Krupansky added a comment - Could somebody give this issue a more accurate and descriptive summary line? I mean it's not really "Guice OR Solr" is it? More like "Guice AND Solr", right? Thanks.
          Hide
          ASF subversion and git services added a comment -

          Commit 1510425 from Grant Ingersoll in branch 'dev/branches/solr_guice_restlet'
          [ https://svn.apache.org/r1510425 ]

          SOLR-4818, SOLR-5091: very basics starting to come together

          Show
          ASF subversion and git services added a comment - Commit 1510425 from Grant Ingersoll in branch 'dev/branches/solr_guice_restlet' [ https://svn.apache.org/r1510425 ] SOLR-4818 , SOLR-5091 : very basics starting to come together

            People

            • Assignee:
              Grant Ingersoll
              Reporter:
              Mikhail Khludnev
            • Votes:
              2 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:

                Development