Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4616

HitRatio in mbean is of type String instead should be float/double.

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.2
    • 4.4
    • Admin UI
    • None
    • Solr 4.2 on JBoss7.1.1

    Description

      While using our existing System Monitoring tool with solr using JMX we noticed that the stats values for Cache is not consistence w.r.t data type.
      decimal values are returned as string instead should be of type float/double.

      e.g hitratio

      Attachments

        Activity

          gbowyer@fastmail.co.uk Greg Bowyer added a comment -

          This should fix it, I am going to test it out shortly (unit tests and such pass, just need to fire up a solr instance)

          gbowyer@fastmail.co.uk Greg Bowyer added a comment - This should fix it, I am going to test it out shortly (unit tests and such pass, just need to fire up a solr instance)
          commit-tag-bot Commit Tag Bot added a comment -

          [branch_4x commit] gbowyer
          http://svn.apache.org/viewvc?view=revision&revision=1478436

          SOLR-4616: Make HitRatio into a float in mbeans

          commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] gbowyer http://svn.apache.org/viewvc?view=revision&revision=1478436 SOLR-4616 : Make HitRatio into a float in mbeans
          commit-tag-bot Commit Tag Bot added a comment -

          [trunk commit] gbowyer
          http://svn.apache.org/viewvc?view=revision&revision=1478450

          SOLR-4616: Make HitRatio into a float in mbeans

          commit-tag-bot Commit Tag Bot added a comment - [trunk commit] gbowyer http://svn.apache.org/viewvc?view=revision&revision=1478450 SOLR-4616 : Make HitRatio into a float in mbeans

          gbowyer@fastmail.co.uk is that going to be in 4.4? Yeah, looks like it. Changing/setting Fix Version then.

          otis Otis Gospodnetic added a comment - gbowyer@fastmail.co.uk is that going to be in 4.4? Yeah, looks like it. Changing/setting Fix Version then.
          romseygeek Alan Woodward added a comment -

          I think it needs a CHANGES.txt entry as well? There may be client code that currently assumes it's a string, which will break on upgrade, so we should give users some warning.

          romseygeek Alan Woodward added a comment - I think it needs a CHANGES.txt entry as well? There may be client code that currently assumes it's a string, which will break on upgrade, so we should give users some warning.
          commit-tag-bot Commit Tag Bot added a comment -

          [trunk commit] gbowyer
          http://svn.apache.org/viewvc?view=revision&revision=1478944

          SOLR-4616: Add Changes.txt entry

          commit-tag-bot Commit Tag Bot added a comment - [trunk commit] gbowyer http://svn.apache.org/viewvc?view=revision&revision=1478944 SOLR-4616 : Add Changes.txt entry
          commit-tag-bot Commit Tag Bot added a comment -

          [branch_4x commit] gbowyer
          http://svn.apache.org/viewvc?view=revision&revision=1478946

          SOLR-4616: Add Changes.txt entry

          commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] gbowyer http://svn.apache.org/viewvc?view=revision&revision=1478946 SOLR-4616 : Add Changes.txt entry
          sarowe Steven Rowe added a comment -

          Bulk close resolved 4.4 issues

          sarowe Steven Rowe added a comment - Bulk close resolved 4.4 issues

          People

            gbowyer@fastmail.co.uk Greg Bowyer
            abakle Aditya
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: