Solr
  1. Solr
  2. SOLR-4616

HitRatio in mbean is of type String instead should be float/double.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.2
    • Fix Version/s: 4.4
    • Component/s: web gui
    • Labels:
      None
    • Environment:

      Solr 4.2 on JBoss7.1.1

      Description

      While using our existing System Monitoring tool with solr using JMX we noticed that the stats values for Cache is not consistence w.r.t data type.
      decimal values are returned as string instead should be of type float/double.

      e.g hitratio

        Activity

        Hide
        Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        Steve Rowe added a comment - Bulk close resolved 4.4 issues
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] gbowyer
        http://svn.apache.org/viewvc?view=revision&revision=1478946

        SOLR-4616: Add Changes.txt entry

        Show
        Commit Tag Bot added a comment - [branch_4x commit] gbowyer http://svn.apache.org/viewvc?view=revision&revision=1478946 SOLR-4616 : Add Changes.txt entry
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] gbowyer
        http://svn.apache.org/viewvc?view=revision&revision=1478944

        SOLR-4616: Add Changes.txt entry

        Show
        Commit Tag Bot added a comment - [trunk commit] gbowyer http://svn.apache.org/viewvc?view=revision&revision=1478944 SOLR-4616 : Add Changes.txt entry
        Hide
        Alan Woodward added a comment -

        I think it needs a CHANGES.txt entry as well? There may be client code that currently assumes it's a string, which will break on upgrade, so we should give users some warning.

        Show
        Alan Woodward added a comment - I think it needs a CHANGES.txt entry as well? There may be client code that currently assumes it's a string, which will break on upgrade, so we should give users some warning.
        Hide
        Otis Gospodnetic added a comment -

        Greg Bowyer is that going to be in 4.4? Yeah, looks like it. Changing/setting Fix Version then.

        Show
        Otis Gospodnetic added a comment - Greg Bowyer is that going to be in 4.4? Yeah, looks like it. Changing/setting Fix Version then.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] gbowyer
        http://svn.apache.org/viewvc?view=revision&revision=1478450

        SOLR-4616: Make HitRatio into a float in mbeans

        Show
        Commit Tag Bot added a comment - [trunk commit] gbowyer http://svn.apache.org/viewvc?view=revision&revision=1478450 SOLR-4616 : Make HitRatio into a float in mbeans
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] gbowyer
        http://svn.apache.org/viewvc?view=revision&revision=1478436

        SOLR-4616: Make HitRatio into a float in mbeans

        Show
        Commit Tag Bot added a comment - [branch_4x commit] gbowyer http://svn.apache.org/viewvc?view=revision&revision=1478436 SOLR-4616 : Make HitRatio into a float in mbeans
        Hide
        Greg Bowyer added a comment -

        This should fix it, I am going to test it out shortly (unit tests and such pass, just need to fire up a solr instance)

        Show
        Greg Bowyer added a comment - This should fix it, I am going to test it out shortly (unit tests and such pass, just need to fire up a solr instance)

          People

          • Assignee:
            Greg Bowyer
            Reporter:
            Aditya
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development