Solr
  1. Solr
  2. SOLR-4200

Significant log noise at INFO from CachingDirectoryFactory#close

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1
    • Fix Version/s: 4.2, 6.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      solr-impl 4.1-SNAPSHOT 1421496 - ncindex - 2012-12-13 14:56:25

      Description

      The following line in CachingDirectoryFactory is resulting in a lot of noise in my branch_4x logs. It was added by Yonik's recent major sync from trunk to branch_4x, r1420992.

      log.info("Releasing directory:" + cacheValue.path);

      This was probably added to debug a problem, but it seems to get called a lot. The specific thing that led me to bring it up is that it is logged four times for every call to /admin/mbeans. When you've got seven cores and you hit them all, it increases the logging from 7 lines to 35. IMHO, it should be moved to debug instead of info.

      INFO - 2012-12-15 13:36:01.674; org.apache.solr.core.CachingDirectoryFactory; Releasing directory:/index/solr4/cores/s0_0/../../data/s0_0
      INFO - 2012-12-15 13:36:01.676; org.apache.solr.core.CachingDirectoryFactory; Releasing directory:/index/solr4/cores/s0_0/../../data/s0_0/index
      INFO - 2012-12-15 13:36:01.676; org.apache.solr.core.CachingDirectoryFactory; Releasing directory:/index/solr4/cores/s0_0/../../data/s0_0
      INFO - 2012-12-15 13:36:01.678; org.apache.solr.core.CachingDirectoryFactory; Releasing directory:/index/solr4/cores/s0_0/../../data/s0_0/index
      INFO - 2012-12-15 13:36:01.679; org.apache.solr.core.SolrCore; [s0build] webapp=/solr path=/admin/mbeans params=

      {qt.path=/admin/mbeans&wt=javabin&stats=true&version=2}

      status=0 QTime=6

      1. SOLR-4200.patch
        2 kB
        Hoss Man
      2. SOLR-4200.patch
        2 kB
        Shawn Heisey

        Activity

        Hide
        Shawn Heisey added a comment -

        Patch against trunk. In addition to moving one log line from info to debug, it makes minor formatting improvements and eliminates one instance of duplicate logging.

        Show
        Shawn Heisey added a comment - Patch against trunk. In addition to moving one log line from info to debug, it makes minor formatting improvements and eliminates one instance of duplicate logging.
        Hide
        Shawn Heisey added a comment -

        Because I just learned about it, I was going to check the precommit target, but it failed because I don't have a new enough python. I was however able to get "ant check-svn-working-copy validate" to pass.

        Show
        Shawn Heisey added a comment - Because I just learned about it, I was going to check the precommit target, but it failed because I don't have a new enough python. I was however able to get "ant check-svn-working-copy validate" to pass.
        Hide
        Otis Gospodnetic added a comment -

        For what it's worth, I heard several users on the ML and off the ML complain about this filling up their logs.

        Show
        Otis Gospodnetic added a comment - For what it's worth, I heard several users on the ML and off the ML complain about this filling up their logs.
        Hide
        Hoss Man added a comment -

        updated patch to trunk (looks like some code moved around).

        i also swaped which of the two duplicate "Closing directory" was kept/removed (seems more prudent to keep the log message in the inner private method doing the actual closing since it is called from multiple places and might be called by others in the future)

        Show
        Hoss Man added a comment - updated patch to trunk (looks like some code moved around). i also swaped which of the two duplicate "Closing directory" was kept/removed (seems more prudent to keep the log message in the inner private method doing the actual closing since it is called from multiple places and might be called by others in the future)
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1453560

        SOLR-4200: Reduce INFO level logging from CachingDirectoryFactory

        Show
        Commit Tag Bot added a comment - [trunk commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1453560 SOLR-4200 : Reduce INFO level logging from CachingDirectoryFactory
        Hide
        Hoss Man added a comment -

        Committed revision 1453560.
        Committed revision 1453578.

        Show
        Hoss Man added a comment - Committed revision 1453560. Committed revision 1453578.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1453578

        SOLR-4200: Reduce INFO level logging from CachingDirectoryFactory (merge r1453560)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1453578 SOLR-4200 : Reduce INFO level logging from CachingDirectoryFactory (merge r1453560)
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Shawn Heisey
            Reporter:
            Shawn Heisey
          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development