[SOLR-4200] Significant log noise at INFO from CachingDirectoryFactory#close

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1
• Fix Version/s: 4.2, 6.0

Environment

solr-impl 4.1-SNAPSHOT 1421496 - ncindex - 2012-12-13 14:56:25

• Assignee: Shawn Heisey
• Reporter: Shawn Heisey
• Created: 15/Dec/12 21:02
• Updated: 09/May/16 18:44
• Resolved: 06/Mar/13 21:34

Description

The following line in CachingDirectoryFactory is resulting in a lot of noise in my branch_4x logs. It was added by Yonik's recent major sync from trunk to branch_4x, r1420992.

log.info("Releasing directory:" + cacheValue.path);

This was probably added to debug a problem, but it seems to get called a lot. The specific thing that led me to bring it up is that it is logged four times for every call to /admin/mbeans. When you've got seven cores and you hit them all, it increases the logging from 7 lines to 35. IMHO, it should be moved to debug instead of info.

INFO - 2012-12-15 13:36:01.674; org.apache.solr.core.CachingDirectoryFactory; Releasing directory:/index/solr4/cores/s0_0/../../data/s0_0
INFO - 2012-12-15 13:36:01.676; org.apache.solr.core.CachingDirectoryFactory; Releasing directory:/index/solr4/cores/s0_0/../../data/s0_0/index
INFO - 2012-12-15 13:36:01.676; org.apache.solr.core.CachingDirectoryFactory; Releasing directory:/index/solr4/cores/s0_0/../../data/s0_0
INFO - 2012-12-15 13:36:01.678; org.apache.solr.core.CachingDirectoryFactory; Releasing directory:/index/solr4/cores/s0_0/../../data/s0_0/index
INFO - 2012-12-15 13:36:01.679; org.apache.solr.core.SolrCore; [s0build] webapp=/solr path=/admin/mbeans params=

{qt.path=/admin/mbeans&wt=javabin&stats=true&version=2}

status=0 QTime=6