Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4111

Context-Sensitive SpellCheck Collation is not really being tested on IndexBasedSpellChecker

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Looks like a typo in the code. SpellCheckCollatorTest.testContextSensitiveCollate() has:

      

          //                     DirectSolrSpellChecker   IndexBasedSpellChecker
          String[] dictionary = {"direct",                "default_teststop" };
          for(int i=0 ; i<1 ; i++) {
          ... test stuff using dictionary[i]...
          }
      

      where it should be

      

          //                     DirectSolrSpellChecker   IndexBasedSpellChecker
          String[] dictionary = {"direct",                "default_teststop" };
          for(int i=0 ; i<=1 ; i++) {
          ... test stuff using dictionary[i]...
          }
      

      due to this, the tests are not being run with a IndexBasedSpellChecker.

        Attachments

          Activity

            People

            • Assignee:
              jdyer James Dyer
              Reporter:
              tflobbe Tomas Eduardo Fernandez Lobbe

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment