Solr
  1. Solr
  2. SOLR-4111

Context-Sensitive SpellCheck Collation is not really being tested on IndexBasedSpellChecker

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Looks like a typo in the code. SpellCheckCollatorTest.testContextSensitiveCollate() has:

      

          //                     DirectSolrSpellChecker   IndexBasedSpellChecker
          String[] dictionary = {"direct",                "default_teststop" };
          for(int i=0 ; i<1 ; i++) {
          ... test stuff using dictionary[i]...
          }
      

      where it should be

      

          //                     DirectSolrSpellChecker   IndexBasedSpellChecker
          String[] dictionary = {"direct",                "default_teststop" };
          for(int i=0 ; i<=1 ; i++) {
          ... test stuff using dictionary[i]...
          }
      

      due to this, the tests are not being run with a IndexBasedSpellChecker.

      1. SOLR-4111.patch
        0.7 kB
        Tomás Fernández Löbbe

        Activity

        Hide
        James Dyer added a comment -

        committed.

        Trunk: r1413036
        4x: r1413038

        Thanks for finding & reporting this, Tomas.

        Show
        James Dyer added a comment - committed. Trunk: r1413036 4x: r1413038 Thanks for finding & reporting this, Tomas.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] James Dyer
        http://svn.apache.org/viewvc?view=revision&revision=1413038

        SOLR-4111: test fix for SpellCheckCollatorTest#testContextSensitiveCollate

        Show
        Commit Tag Bot added a comment - [branch_4x commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1413038 SOLR-4111 : test fix for SpellCheckCollatorTest#testContextSensitiveCollate
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] James Dyer
        http://svn.apache.org/viewvc?view=revision&revision=1413036

        SOLR-4111: test fix for SpellCheckCollatorTest#testContextSensitiveCollate

        Show
        Commit Tag Bot added a comment - [trunk commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1413036 SOLR-4111 : test fix for SpellCheckCollatorTest#testContextSensitiveCollate
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] James Dyer
        http://svn.apache.org/viewvc?view=revision&revision=1423067

        SOLR-4111: fix occasional failures

        Show
        Commit Tag Bot added a comment - [trunk commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1423067 SOLR-4111 : fix occasional failures
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] James Dyer
        http://svn.apache.org/viewvc?view=revision&revision=1423093

        SOLR-4111: fix occasional failures

        Show
        Commit Tag Bot added a comment - [branch_4x commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1423093 SOLR-4111 : fix occasional failures
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] James Dyer
        http://svn.apache.org/viewvc?view=revision&revision=1413038

        SOLR-4111: test fix for SpellCheckCollatorTest#testContextSensitiveCollate

        Show
        Commit Tag Bot added a comment - [branch_4x commit] James Dyer http://svn.apache.org/viewvc?view=revision&revision=1413038 SOLR-4111 : test fix for SpellCheckCollatorTest#testContextSensitiveCollate

          People

          • Assignee:
            James Dyer
            Reporter:
            Tomás Fernández Löbbe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development