[SOLR-4111] Context-Sensitive SpellCheck Collation is not really being tested on IndexBasedSpellChecker

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 4.0
• Fix Version/s: 4.1, 6.0
• Assignee: James Dyer
• Reporter: Tomas Eduardo Fernandez Lobbe
• Created: 23/Nov/12 18:59
• Updated: 09/May/16 18:49
• Resolved: 23/Nov/12 19:29

Description

Looks like a typo in the code. SpellCheckCollatorTest.testContextSensitiveCollate() has:



    //                     DirectSolrSpellChecker   IndexBasedSpellChecker
    String[] dictionary = {"direct",                "default_teststop" };
    for(int i=0 ; i<1 ; i++) {
    ... test stuff using dictionary[i]...
    }

where it should be



    //                     DirectSolrSpellChecker   IndexBasedSpellChecker
    String[] dictionary = {"direct",                "default_teststop" };
    for(int i=0 ; i<=1 ; i++) {
    ... test stuff using dictionary[i]...
    }

due to this, the tests are not being run with a IndexBasedSpellChecker.