Solr
  1. Solr
  2. SOLR-4055

Remove/Reload the collection has the thread safe issue.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA, 4.0-BETA, 4.0
    • Fix Version/s: 4.1, 6.0
    • Component/s: SolrCloud
    • Labels:
      None
    • Environment:

      Solr cloud

      Description

      OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
      The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.

      In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.

      The easy fix is clone the ModifiableSolrParams for every request.

      1. patch-4055
        2 kB
        Raintung Li

        Activity

        Hide
        Raintung Li added a comment -

        the bug patch

        Show
        Raintung Li added a comment - the bug patch
        Hide
        Mark Miller added a comment -

        Great catch Raintung!

        Show
        Mark Miller added a comment - Great catch Raintung!
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1408126

        SOLR-4055: Fix a thread safety issue with the Collections API that could cause actions to be targeted at the wrong SolrCores.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1408126 SOLR-4055 : Fix a thread safety issue with the Collections API that could cause actions to be targeted at the wrong SolrCores.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1408125

        SOLR-4055: Fix a thread safety issue with the Collections API that could cause actions to be targeted at the wrong SolrCores.

        Show
        Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1408125 SOLR-4055 : Fix a thread safety issue with the Collections API that could cause actions to be targeted at the wrong SolrCores.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1408134

        SOLR-4055: Remove tabs and format to Lucene convention

        Show
        Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1408134 SOLR-4055 : Remove tabs and format to Lucene convention
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1408135

        SOLR-4055: Remove tabs and format to Lucene convention

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1408135 SOLR-4055 : Remove tabs and format to Lucene convention
        Hide
        Mark Miller added a comment -

        Thanks Raintung!

        Show
        Mark Miller added a comment - Thanks Raintung!
        Hide
        Mark Miller added a comment -

        See SOLR-4114 - we missed a spot.

        Show
        Mark Miller added a comment - See SOLR-4114 - we missed a spot.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1414744

        SOLR-4055: clone params for create calls

        Show
        Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1414744 SOLR-4055 : clone params for create calls
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1414760

        SOLR-4055: clone params for create calls

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1414760 SOLR-4055 : clone params for create calls
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1414760

        SOLR-4055: clone params for create calls

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1414760 SOLR-4055 : clone params for create calls
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1408135

        SOLR-4055: Remove tabs and format to Lucene convention

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1408135 SOLR-4055 : Remove tabs and format to Lucene convention
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1408126

        SOLR-4055: Fix a thread safety issue with the Collections API that could cause actions to be targeted at the wrong SolrCores.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1408126 SOLR-4055 : Fix a thread safety issue with the Collections API that could cause actions to be targeted at the wrong SolrCores.

          People

          • Assignee:
            Mark Miller
            Reporter:
            Raintung Li
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development