[SOLR-4055] Remove/Reload the collection has the thread safe issue.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0-ALPHA, 4.0-BETA, 4.0
• Fix Version/s: 4.1, 6.0
• Component/s: SolrCloud

Environment

Solr cloud

• Assignee: Mark Miller
• Reporter: Raintung Li
• Created: 09/Nov/12 10:09
• Updated: 09/May/16 18:59
• Resolved: 28/Nov/12 15:43

Description

OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.

In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.

The easy fix is clone the ModifiableSolrParams for every request.