Solr
  1. Solr
  2. SOLR-3322

Add more context to IndexReaderFactory.newReader

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      In some situations where a custom IndexReaderFactory is used the amount of information passed to the newReader(..) call is too small. E.g. if a factory needs to access some external data that depends on schema or even on the collection name then it has no way to obtain that context.

      We cannot use SolrCoreAware here because this method is called before SolrCore is ready.

      I propose to simply change the signature and add a SolrCore argument. Even though SolrCore is not fully valid at this point, still the most useful properties there are valid (schema, descriptor, config, etc...).

      1. SOLR-3322.patch
        3 kB
        Andrzej Bialecki

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Andrzej Bialecki
            Reporter:
            Andrzej Bialecki
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development