Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3322

Add more context to IndexReaderFactory.newReader

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      In some situations where a custom IndexReaderFactory is used the amount of information passed to the newReader(..) call is too small. E.g. if a factory needs to access some external data that depends on schema or even on the collection name then it has no way to obtain that context.

      We cannot use SolrCoreAware here because this method is called before SolrCore is ready.

      I propose to simply change the signature and add a SolrCore argument. Even though SolrCore is not fully valid at this point, still the most useful properties there are valid (schema, descriptor, config, etc...).

        Attachments

          Activity

            People

            • Assignee:
              ab Andrzej Bialecki
              Reporter:
              ab Andrzej Bialecki

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment