Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2654

<lockType/> not used consistently in all places Directory objects are instantiated

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0-ALPHA
    • None
    • None

    Description

      nipunb noted on the mailing list then when configuring solr to use an alternate <lockType/> (ie: simple) the stats for the SolrIndexSearcher list NativeFSLockFactory being used by the Directory.

      The problem seems to be that SolrIndexConfig is not consulted when constructing Directory objects used for IndexReader (it's only used by SolrIndexWriter)

      I don't think this is a problem in most cases since the IndexReaders should all be readOnly in the core solr code) but plugins could attempt to use them in other ways. In general it seems like a really bad bug waiting to happen.

      Attachments

        1. SOLR-2654.patch
          62 kB
          Mark Miller
        2. SOLR-2654.patch
          62 kB
          Mark Miller
        3. SOLR-2654.patch
          62 kB
          Mark Miller
        4. SOLR-2654.patch
          64 kB
          Mark Miller
        5. SOLR-2698.patch
          63 kB
          Mark Miller
        6. SOLR-2654.patch
          53 kB
          Mark Miller
        7. SOLR-2654.patch
          50 kB
          Mark Miller
        8. SOLR-2654.patch
          42 kB
          Mark Miller
        9. SOLR-2654.patch
          42 kB
          Mark Miller

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            markrmiller@gmail.com Mark Miller
            hossman Chris M. Hostetter
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment