Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2702

Add support for NRTCachingDirectory

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-BETA, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      would be nice to have this option for the new NRT support

      1. SOLR-2702.patch
        13 kB
        Yonik Seeley
      2. SOLR-2702.patch
        3 kB
        Yonik Seeley

        Issue Links

          Activity

          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Getting this issue right counts on SOLR-2654

          Show
          markrmiller@gmail.com Mark Miller added a comment - Getting this issue right counts on SOLR-2654
          Hide
          jasonrutherglen Jason Rutherglen added a comment -

          Can we mark this for Lucene 3.x as well?

          Show
          jasonrutherglen Jason Rutherglen added a comment - Can we mark this for Lucene 3.x as well?
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          We should perhaps even configure this to be used by the example server by default given that the performance impact should be negligible if NRT isn't being used.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - We should perhaps even configure this to be used by the example server by default given that the performance impact should be negligible if NRT isn't being used.
          Hide
          jasonrutherglen Jason Rutherglen added a comment -

          This issue [only] needs to add configuration options given NRTCachingDirectoryFactory is in trunk.

          Show
          jasonrutherglen Jason Rutherglen added a comment - This issue [only] needs to add configuration options given NRTCachingDirectoryFactory is in trunk.
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Another issue currently is that this will not work with SolrCloud correctly because it is not detected as an FSDir it appears, and so we don't get the index dir, and replication does not work.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Another issue currently is that this will not work with SolrCloud correctly because it is not detected as an FSDir it appears, and so we don't get the index dir, and replication does not work.
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          Easiest approach for now would be to add a NRTCachingDirectory.getDelegate() call and then also check for that.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - Easiest approach for now would be to add a NRTCachingDirectory.getDelegate() call and then also check for that.
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          Quick patch for the issue of getting the index directory. No new tests, but all existing tests pass.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - Quick patch for the issue of getting the index directory. No new tests, but all existing tests pass.
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          Here's the final patch that changes the default to NRT and also changes the tests that require an FS dir to use NRT most of the time. Looping adds and soft commits on OS-X, I saw about a 3x performance increase in turnaround time.

          All tests pass and I plan on committing shortly.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - Here's the final patch that changes the default to NRT and also changes the tests that require an FS dir to use NRT most of the time. Looping adds and soft commits on OS-X, I saw about a 3x performance increase in turnaround time. All tests pass and I plan on committing shortly.
          Hide
          hossman Hoss Man added a comment -

          bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment

          Show
          hossman Hoss Man added a comment - bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment
          Hide
          rcmuir Robert Muir added a comment -

          rmuir20120906-bulk-40-change

          Show
          rcmuir Robert Muir added a comment - rmuir20120906-bulk-40-change
          Hide
          hossman Hoss Man added a comment -

          this appears to have been committed and included in 4.0-BETA

          Show
          hossman Hoss Man added a comment - this appears to have been committed and included in 4.0-BETA

            People

            • Assignee:
              yseeley@gmail.com Yonik Seeley
              Reporter:
              markrmiller@gmail.com Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development