Solr
  1. Solr
  2. SOLR-2221

DIH: use StrUtils.parseBool() to get values of boolean options of import command

    Details

      Description

      Currently, debug option for full-import/delta-import accepts only "on" for true:

      if ("on".equals(requestParams.get("debug"))) {
        debug = true;
        rows = 10;
        // Set default values suitable for debug mode
        commit = false;
        clean = false;
        verbose = "true".equals(requestParams.get("verbose"))
                || "on".equals(requestParams.get("verbose"));
      }
      

      and other boolean options uses Boolean.parseBoolean(String). We would like to use StrUtils.parseBool() that accepts true, on and yes for true, and false, off and no for false.

      1. SOLR-2221.patch
        5 kB
        Koji Sekiguchi

        Activity

        Koji Sekiguchi created issue -
        Koji Sekiguchi made changes -
        Field Original Value New Value
        Component/s contrib - DataImportHandler [ 12312438 ]
        Hide
        Koji Sekiguchi added a comment -

        The patch attached. I'll commit tomorrow.

        Show
        Koji Sekiguchi added a comment - The patch attached. I'll commit tomorrow.
        Koji Sekiguchi made changes -
        Attachment SOLR-2221.patch [ 12459014 ]
        Koji Sekiguchi made changes -
        Assignee Koji Sekiguchi [ koji ]
        Hide
        Koji Sekiguchi added a comment -

        trunk: Committed revision 1032446.
        branch_3x: Committed revision 1032451.

        Show
        Koji Sekiguchi added a comment - trunk: Committed revision 1032446. branch_3x: Committed revision 1032451.
        Koji Sekiguchi made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release
        Grant Ingersoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Koji Sekiguchi
            Reporter:
            Koji Sekiguchi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development