Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2221

DIH: use StrUtils.parseBool() to get values of boolean options of import command

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Currently, debug option for full-import/delta-import accepts only "on" for true:

      if ("on".equals(requestParams.get("debug"))) {
        debug = true;
        rows = 10;
        // Set default values suitable for debug mode
        commit = false;
        clean = false;
        verbose = "true".equals(requestParams.get("verbose"))
                || "on".equals(requestParams.get("verbose"));
      }
      

      and other boolean options uses Boolean.parseBoolean(String). We would like to use StrUtils.parseBool() that accepts true, on and yes for true, and false, off and no for false.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            koji Koji Sekiguchi
            koji Koji Sekiguchi
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment