Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1825

SolrQuery.addFacetQuery should call setFacet(true)

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 1.5
    • 4.0-ALPHA
    • clients - java
    • None

    Description

      Note that solrQuery.addFacetField(name) does enable faceting automatically but addFacetQuery does not. This is inconsistent.

      Attachments

        1. SOLR-1825.patch
          1 kB
          Chris Male
        2. solr1825.patch
          0.5 kB
          Tommaso Teofili

        Activity

          attached patch which adds set(FacetParams.FACET, true); to the addFacetQuery method of SolrQuery

          teofili Tommaso Teofili added a comment - attached patch which adds set(FacetParams.FACET, true); to the addFacetQuery method of SolrQuery
          cmale Chris Male added a comment -

          This has frustrated me for awhile too. Any objections?

          cmale Chris Male added a comment - This has frustrated me for awhile too. Any objections?
          cmale Chris Male added a comment -

          Updated patch which includes test verifying behavior.

          Ready to go.

          cmale Chris Male added a comment - Updated patch which includes test verifying behavior. Ready to go.
          ryantxu Ryan McKinley added a comment -

          +1

          ryantxu Ryan McKinley added a comment - +1

          +1 - shoot for it

          simonw Simon Willnauer added a comment - +1 - shoot for it
          cmale Chris Male added a comment -

          Committed revision 1144564.

          cmale Chris Male added a comment - Committed revision 1144564.

          People

            cmale Chris Male
            dsmiley David Smiley
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: