Solr
  1. Solr
  2. SOLR-1825

SolrQuery.addFacetQuery should call setFacet(true)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 4.0-ALPHA
    • Component/s: clients - java
    • Labels:
      None

      Description

      Note that solrQuery.addFacetField(name) does enable faceting automatically but addFacetQuery does not. This is inconsistent.

      1. SOLR-1825.patch
        1 kB
        Chris Male
      2. solr1825.patch
        0.5 kB
        Tommaso Teofili

        Activity

        Hide
        Chris Male added a comment -

        Committed revision 1144564.

        Show
        Chris Male added a comment - Committed revision 1144564.
        Hide
        Simon Willnauer added a comment -

        +1 - shoot for it

        Show
        Simon Willnauer added a comment - +1 - shoot for it
        Hide
        Ryan McKinley added a comment -

        +1

        Show
        Ryan McKinley added a comment - +1
        Hide
        Chris Male added a comment -

        Updated patch which includes test verifying behavior.

        Ready to go.

        Show
        Chris Male added a comment - Updated patch which includes test verifying behavior. Ready to go.
        Hide
        Chris Male added a comment -

        This has frustrated me for awhile too. Any objections?

        Show
        Chris Male added a comment - This has frustrated me for awhile too. Any objections?
        Hide
        Tommaso Teofili added a comment -

        attached patch which adds set(FacetParams.FACET, true); to the addFacetQuery method of SolrQuery

        Show
        Tommaso Teofili added a comment - attached patch which adds set(FacetParams.FACET, true); to the addFacetQuery method of SolrQuery

          People

          • Assignee:
            Chris Male
            Reporter:
            David Smiley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development