[SOLR-1674] improve analysis tests, cut over to new API

• Type: Test
• Status: Reopened
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 4.9, 6.0
• Component/s: Schema and Analysis
• Assignee: Robert Muir
• Reporter: Robert Muir
• Created: 18/Dec/09 14:45
• Updated: 09/May/16 18:43

Description

This patch

• converts all analysis tests to use the new tokenstream api
• converts most tests to use the more stringent assertion mechanisms from lucene
• adds new tests to improve coverage

Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
The problems with this filter are more serious, the previous tests were essentially a no-op.
The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.

Issue Links

• is part of: SOLR-1657 convert the rest of solr to use the new tokenstream API