Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1674

improve analysis tests, cut over to new API

    Details

    • Type: Test
    • Status: Reopened
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 4.9, 6.0
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      This patch

      • converts all analysis tests to use the new tokenstream api
      • converts most tests to use the more stringent assertion mechanisms from lucene
      • adds new tests to improve coverage

      Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
      The problems with this filter are more serious, the previous tests were essentially a no-op.
      The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.

        Attachments

        1. SOLR-1674_speedup.patch
          19 kB
          Robert Muir
        2. SOLR-1674.patch
          182 kB
          Robert Muir
        3. SOLR-1674.patch
          180 kB
          Robert Muir

          Issue Links

            Activity

              People

              • Assignee:
                rcmuir Robert Muir
                Reporter:
                rcmuir Robert Muir
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: