Solr
  1. Solr
  2. SOLR-1588

FieldProperties contains large commented code block

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.5, 3.1, 4.0-ALPHA
    • Component/s: search
    • Labels:
      None
    • Environment:

      My local MacBook pro laptop.

      Description

      Lines 102-133 in o.a.solr.schema.FieldProperties contain a large commented out block of code. It's generally a good thing to not commit this type of code – if it's needed it can be looked up by the CM system for a prior revision. Trivial patch attached that removes the code block.

      (note I found this while trying to understand the FieldType hierarchy with the goal of working on SOLR-1586 to help out...)

        Activity

        Hide
        Hoss Man added a comment -

        makes sense to me.

        Committed revision 898124.

        Show
        Hoss Man added a comment - makes sense to me. Committed revision 898124.
        Hide
        Hoss Man added a comment -

        Correcting Fix Version based on CHANGES.txt, see this thread for more details...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Show
        Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Hoss Man
            Reporter:
            Chris A. Mattmann
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development