Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1588

FieldProperties contains large commented code block

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 1.4
    • 1.5, 3.1, 4.0-ALPHA
    • search
    • None
    • My local MacBook pro laptop.

    Description

      Lines 102-133 in o.a.solr.schema.FieldProperties contain a large commented out block of code. It's generally a good thing to not commit this type of code – if it's needed it can be looked up by the CM system for a prior revision. Trivial patch attached that removes the code block.

      (note I found this while trying to understand the FieldType hierarchy with the goal of working on SOLR-1586 to help out...)

      Attachments

        1. SOLR-1588.Mattmann.112209.patch.txt
          2 kB
          Chris A. Mattmann

        Activity

          People

            hossman Chris M. Hostetter
            chrismattmann Chris A. Mattmann
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: