[SOLR-15629] Improve the way we "expect" ERROR messages in tests

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 14/Sep/21 01:43
• Updated: 15/Oct/21 22:12

Description

The original goal of this Jira is now tracked in the SOLR-15697 subtask.

 

At a broader level this Jira is looking a ways to make it possible for tests to intercept & inspect log messages produced by SOlr during the test, and make assertions about them.

Ideally we should reach the point where any ERROR or WARN message logged by a test that isn't explicitly "expected" would cause a test failure.

Issue Links

• is related to: SOLR-15628 SolrException.log doesn't pass Throwable to Logger correctly

Sub-Tasks

• replace SolrException.ignorePatterns with something that doesn't depend on SolrException.log(): Closed
• replace all SolrException.log usage in Solr to just call log.error(...) directly: Closed
• remove deprecated SolrException.ignorePatterns realted code for 9.0: Closed
• Add a "LogListener" helper class that makes it easy to inspect & assert expected log messages: Closed
• Add TestRule support for ErrorLogMuter & LogListener: Open