[SOLR-15703] replace all SolrException.log usage in Solr to just call log.error(...) directly

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: main (10.0), 9.3
• Labels: newdev
• Assignee: Kevin Risden
• Reporter: Chris M. Hostetter
• Created: 19/Oct/21 21:17
• Updated: 02/Apr/23 15:13
• Resolved: 02/Apr/23 15:13

Description

There is a lot of code in Solr that uses SolrException.log(log, ..) as a way to ensure that the resulting exception can be "ignored" in tests via SolrException.ignorePatterns / SolrTestCaseJ4.ignoreException()

This "test feature" is being cleaned up / replaced in SOLR-15697 so that any log message can be "muted" - meaning we don't need this special hook/hack – we can replace all calls to SolrException.log(log, ..) with (more efficient) direct calls to log.error(..) 

But this change isn't trivially to do in a scripted/automated manner – notably many of these SolrException.log(log, ..) use string concatenation that needs to be replaced with logging parameterization to pass our validateLogCalls check.

Issue Links

• is blocked by: SOLR-15697 replace SolrException.ignorePatterns with something that doesn't depend on SolrException.log()
• links to: GitHub Pull Request #1513
• links to: GitHub Pull Request #1533