[SOLR-14920] Format Java code automatically and enforce it in Solr

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0
• Labels: codestyle formatting
• Assignee: Kevin Risden
• Reporter: Erick Erickson
• Created: 08/Oct/20 11:24
• Updated: 12/May/22 00:27
• Resolved: 26/Apr/22 15:15

Description

See the discussion at: LUCENE-9564.

This is a placeholder for the present, I'm reluctant to do this to the Solr code base until after:

• we have some Solr-specific consensus
• we have some clue what this means for the reference impl.

Reconciling the reference impl will be difficult enough without a zillion format changes to add to the confusion.

So my proposal is

1> do this.

2> Postpone this until after the reference impl is merged.

3> do this in one single commit for reasons like being able to conveniently have this separated out from git blame.

Assigning to myself so it doesn't get lost, but anyone who wants to take it over please feel free.

Issue Links

• is related to: LUCENE-9564 Format code automatically and enforce it
• relates to: SOLR-16049 Upgrade to spotless 6.3.0
• links to: GitHub Pull Request #126
• links to: GitHub Pull Request #162
• links to: GitHub Pull Request #189
• links to: GitHub Pull Request #678
• links to: GitHub Pull Request #679
• links to: GitHub Pull Request #680
• links to: GitHub Pull Request #683
• links to: GitHub Pull Request #704
• links to: GitHub Pull Request #705
• links to: GitHub Pull Request #706
• links to: GitHub Pull Request #711
• links to: GitHub Pull Request #713
• links to: GitHub Pull Request #720
• links to: GitHub Pull Request #721
• links to: GitHub Pull Request #722
• links to: GitHub Pull Request #723