[SOLR-14800] Filter default score should be the provided boost, not zero

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: search
• Assignee: Unassigned
• Reporter: David Smiley
• Created: 01/Sep/20 05:59
• Updated: 16/Feb/22 00:11
• Resolved: 14/Feb/22 13:58

Description

I see some inconsistency in what some "constant scoring queries" return for a score. Lucene's ConstantScoreQuery yields 1 but it can be boosted (e.g. multiplied by whatever). SolrConstantScoreQuery (which wraps a Filter) does the same. Filter itself (which was modified to BE a Query years ago) yields 0 (not boostable), and so if it's used as a Query (vs only used as a supplier of DocIdSet), it's always 0. Nearly all ConstantScoreQuery usages use the provided boost (often indirectly via score() which is initialized to the boost), and do not hard-code 0. I think we should standardize on this approach.

Note: ToParentBlockJoinQuery (and Child equivalent) use 0 (by code inspection) but this seems to be an anomaly.

Issue Links

• blocks: SOLR-14619 Avoid needless calls to SolrIndexSearcher.getDocSet(query)