[SOLR-12336] Remove Filter from Solr

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: search
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 09/May/18 17:53
• Updated: 12/May/22 00:26
• Resolved: 18/Mar/22 18:14

Description

Over a series of Lucene releases, the old Filter was made to extend Query (LUCENE-1518) and then was removed from Lucene (moved to Solr in LUCENE-6583); BooleanClause.Occur.FILTER (LUCENE-6227) with some other API enhancements including TwoPhaseIterator replaced the need for the old Filter. Filter is now a Solr thing, and there are various related classes like QueryWrapperFilter and SolrConstantScoreQuery that depend on it. We should remove some of this technical-debt / bit-rot, making refactorings as needed to retain functionality. Leaving things as-is is needless complexity and can impede performance when there is needless wrapping/layers.
CC @yonik

Issue Links

• is a parent of: SOLR-14391 Remove getDocSet's manual doc collection logic; remove ScoreFilter
• requires: SOLR-15185 Improve "hash" QParser
• links to: GitHub Pull Request #529
• links to: GitHub Pull Request #638
• mentioned in: Page Loading...

Sub-Tasks

• Remove QueryWrapperFilter: Closed
• Use TwoPhaseIterator for non-cached filter queries: Closed
• Replace Solr's FunctionRangeQuery with Lucene's: Patch Available
• add DocSet.getDocIdSetIterator(LeafReaderContext): Closed
• Refactor BlockJoin to not use Filter.java: Closed
• Filter default score should be the provided boost, not zero: Resolved
• Add DocSetQuery in lieu of DocSet.getTopFilter: Closed