[SOLR-13983] remove or replace process execution in SystemInfoHandler

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.5
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 29/Nov/19 20:45
• Updated: 20/Apr/20 16:43
• Resolved: 05/Mar/20 12:20

Description

SystemInfoHandler is the only place in solr code executing processes.

Since solr is a server/long running process listening to HTTP, ideally process execution could be disabled (e.g. with security manager). But first this code needs to be removed or replaced, so that there is no legitimate use of it:

try { 
      if (!Constants.WINDOWS) {
        info.add( "uname",  execute( "uname -a" ) );
        info.add( "uptime", execute( "uptime" ) );
      }
    } catch( Exception ex ) {
      log.warn("Unable to execute command line tools to get operating system properties.", ex);
    } 
    return info;

It already looks like its getting data from OS MXbean here, so maybe this logic is simply outdated or not needed. It seems to be "best-effort" anyway. Alternatively similar stuff could be fetched by reading from e.g. /proc file system location if needed.

Issue Links

• is duplicated by: SOLR-14416 Nodes view doesn't work correctly when Solr is hosted on Windows