Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13983

remove or replace process execution in SystemInfoHandler

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.5
    • Component/s: None
    • Labels:
      None

      Description

      SystemInfoHandler is the only place in solr code executing processes.

      Since solr is a server/long running process listening to HTTP, ideally process execution could be disabled (e.g. with security manager). But first this code needs to be removed or replaced, so that there is no legitimate use of it:

      try { 
            if (!Constants.WINDOWS) {
              info.add( "uname",  execute( "uname -a" ) );
              info.add( "uptime", execute( "uptime" ) );
            }
          } catch( Exception ex ) {
            log.warn("Unable to execute command line tools to get operating system properties.", ex);
          } 
          return info;
      

      It already looks like its getting data from OS MXbean here, so maybe this logic is simply outdated or not needed. It seems to be "best-effort" anyway. Alternatively similar stuff could be fetched by reading from e.g. /proc file system location if needed.

        Attachments

        1. SOLR-13983.patch
          4 kB
          Robert Muir

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                rcmuir Robert Muir
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: