Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13794

Delete solr/core/src/test-files/solr/configsets/_default

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.5, main (9.0)
    • Component/s: None
    • Labels:
      None

      Description

      For as long as we've had a _default configset in solr, we've also had a copy of that default in core/src/test-files/ - as well as a unit test that confirms they are identical.

      It's never really been clear to me why we have this duplication, instead of just having the test-framework take the necessary steps to ensure that server/solr/configsets/_default is properly used when running tests.

      I'd like to propose we eliminate the duplication since it only ever seems to cause problems (notably spurious test failures when people modify the _default configset w/o remembering that they need to make identical edits to the test-files clone) and instead have SolrTestCase set the (already existing & supported) solr.default.confdir system property to point to the (already existing) ExternalPaths.DEFAULT_CONFIGSET

        Attachments

        1. SOLR-13794_code_only.patch
          13 kB
          Chris M. Hostetter
        2. SOLR-13794_code_only.patch
          13 kB
          Chris M. Hostetter
        3. SOLR-13794.patch
          243 kB
          Chris M. Hostetter
        4. SOLR-13794.patch
          250 kB
          Chris M. Hostetter

        Issue Links

          Activity

            People

            • Assignee:
              hossman Chris M. Hostetter
              Reporter:
              hossman Chris M. Hostetter

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment