Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-13308

Move SystemPropertiesRestoreRule to SolrTestCase

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 8.1, main (9.0)
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Kevin Risden just traced flaky HDFS tests to not clearing sysprops, see the discussion at SOLR-13297.

      Part of SOLR-13268 is to derive all Solr test classes from SolrTestCase.

      Once that's pushed, does it make sense to put that rule in SolrTestCase so it gets performed automagically so this kind of error doesn't creep back in?

      I don't know the details of how that rule is implemented or whether this makes sense at that level but wanted to discuss.

      I've assigned it to myself, but that's just so I don't lose track of it, but anyone else who wants to pick it up please feel free.

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              erickerickson Erick Erickson
              Reporter:
              erickerickson Erick Erickson

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment